nextcloud / nextcloud/talk-android

Turnserver TLS certificate not checked

Open
#988 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: call ☎️ security
Dominant language
Kotlin
Stars
739
Forks
321
Avg merge
14h 59m
Merged PRs (30d)
151

Description

Steps to reproduce

  1. Set up a turn server with domain turn.server.tld
  2. In the turn server configuration, specify an TLS certificate to be used from a different domain e.g. different.domain.tld
  3. Enter the turn/stun server domain turn.server.tld to nextcloud talk settings in your nextcloud instance.
  4. Start a call via nextcloud talk app.
Expected behaviour

The call should not start as we have a certificate mismatch.

Actual behaviour

The call is initiated without error.

Talk app

android v8.2.0

Custom Signaling server configured:
no

Custom TURN server configured:
yes, coturn

Custom STUN server configured:
yes, coturn

Browser

Microphone available:
yes

Camera available:
yes

Operating system:
Ubuntu 20.04.1 LTS

Browser name:
Chromium

Browser version:
Chromium Version 88.0.4324.96 (Official Build) snap (64-bit)

Server configuration

Operating system
Debian 10

Web server:
Nginx

Database:
Maria 10.5.8

PHP version:
7.4.14

Nextcloud Version:
20.0.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Android Talk TURN/STUN connection path described in the reproduction steps and trace how the configured server certificate is validated. Reproduce the mismatched-certificate setup, then verify that the call is rejected with an error rather than initiated.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.