nextcloud / nextcloud/talk-android

Immediate back button after "start/join call" results in broken state

Open
#724 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: call ☎️ high
Dominant language
Kotlin
Stars
739
Forks
321
Avg merge
14h 59m
Merged PRs (30d)
151

Description

Steps
  1. Have a conversation with a slow internet connection
  2. Go to a conversation
  3. Press "Start call"
  4. Immediately press back
Expected

If the join call request finishes, it should be left again afterwards

Actually

"Leave call" reaches the server before the join finishes.
This leads to wrong order of join/leave messages and results in "has_call" being left on for the conversation. Of course the API should make sure to clear up the state when a person leaves, but then again the requests should also be sent in the correct order (dont leave before join finished)

Bildschirmfoto von 2020-02-11 15-09-14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Android flow behind the “Start call”/join and “Leave call” actions, then reproduce the sequence on a slow connection. Trace the API request ordering when back is pressed immediately; done means the join completes before leave is sent and the conversation’s call state is cleared.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
audio-video-rtc, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.