nextcloud / nextcloud/talk-android

Launching an application with outdated user credentials blocks that user.

Open
#6,125 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
Kotlin
Stars
739
Forks
321
Avg merge
14h 59m
Merged PRs (30d)
151

Description

Steps to reproduce
  1. Launch the app with outdated user credentials, you'll see it opens and show a list of conversations. You can open the conversation, but its data isn't updated.
  2. Meanwhile, hundreds of "Login failed: 'user' (Remote IP: 'xxx.xxx.xxx.xxx')" messages appear in the system server log, and, as icing on the cake:
no app in context ServiceUnavailable
OC\User\DisabledUserException: Account disabled

webdav ServiceUnavailable
OC\User\DisabledUserException: Account disabled

no app in context DisabledUserException Account disabled
  1. Brute force protection is configured on the server by default.
Expected behaviour

Don't open app if login is failed

Actual behaviour

The app is hogging the server until the protection blocks the user.

Device brand and model

Samsung

Android version

16

Nextcloud Talk app version

23.0.0 (the same behaviour can be seen on the QA apk from the https://github.com/nextcloud/talk-android/pull/6085 pr)

Nextcloud server version

32.0.8

Talk version

22.0.11

Custom Signaling server configured

None

Custom TURN server configured

Yes

Custom STUN server configured

Yes

Android logs

No response

Server log

Additional information

By "outdated user credentials" I mean changed/removed application passwords, not the user password. For me those passwords became obsolete when the user was disabled the first time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the Android app with a changed or removed application password and observe the login flow and repeated server requests. The fix is done when failed authentication prevents the app from opening and no repeated login attempts continue against the server.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.