nextcloud / nextcloud/talk-android
Improve ConversationsListScreen wrapping API calls by viewmodel and repository
Open
Nobody has claimed this yet.
1. to develop
approved
enhancement
feature: conversations 📄
technical debt
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
@mahibi Follow-up for #6008 specifically https://github.com/nextcloud/talk-android/pull/6008#issuecomment-4178890725
- The ConversationsListScreen now directly contains api calls which would be nicer if it's wrapped away by a viewmodel and repository.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading ConversationsListScreen and the context in issue #6008 and pull request 6008. Identify the API calls currently in the screen, then confirm completion when those calls are accessed through a viewmodel and repository rather than directly from the screen.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100