nextcloud / nextcloud/talk-android
Pinch zooming for images broken
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
Pinch zooming is only possible after initial double-tap.
For v23.0 it worked without initial double-tap.
Might be broken since https://github.com/nextcloud/talk-android/pull/5756
Also btw if it makes sense for the same fix: The threshold to close images is very low, so images are closed accidentally. Might make sense to have a look and modify this when fixing the zoom.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the image-viewer gesture behavior, then compare the current implementation with the changes in pull request #5756. Verify that pinch zoom works without an initial double-tap and that images are not closed by small gestures; check the relevant Android tests or add coverage if the project provides them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100