nextcloud / nextcloud/talk-android
Revert some filtering logic
@mahibi is already working on this.
Since May 27, 2025.
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
originally posted in https://github.com/nextcloud/talk-android/pull/4996#issuecomment-2912162519
tbh i am confused by some logic and naming that was introduced with the event conversations PR's (https://github.com/nextcloud/talk-android/pull/4846 & https://github.com/nextcloud/talk-android/pull/4969).
With naming i mean for example: i was quite confused that nearFutureEventConversationItems are now the items that are shown on the main conversation list.
Before it was:
conversationItems
and
conversationItemWithHeader
(which now serve a different purpose)
and
searchableConversationItems
contained all the items that were shown in search mode.
As far as i see the PR's introduced more logic for filtering that could have been accomplished with existing logic.
Especially the changes in FilterConversationFragment were not necessary as far as i see.
This was already solved by processSubmit() which called filterConversation() in ConversationsListActivity.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.