nextcloud / nextcloud/talk-android
Send silentFor array parameter when switch-to an extended_conversation
Open
Nobody has claimed this yet.
1. to develop
bug
feature: call ☎️
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
- To resolve https://github.com/nextcloud/spreed/issues/14983 clients need to tell the backend to send call notifications and ignore the previous participant
- API in progress in https://github.com/nextcloud/spreed/pull/15083
- Starting point should be
https://github.com/nextcloud/talk-android/blob/1e1a8f7f21c0b3d2f74a4278bb3f09703b0e0533/app/src/main/java/com/nextcloud/talk/signaling/SignalingMessageReceiver.java#L295 - API call where you need to send the silentFor is
https://github.com/nextcloud/talk-android/blob/1e1a8f7f21c0b3d2f74a4278bb3f09703b0e0533/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt#L3024
The silentFor array can be set to the conversation.name of the previous conversation
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in SignalingMessageReceiver.java around line 295 and ChatActivity.kt around line 3024, then review the API changes in pull request #15083. Update the switch-to extended_conversation request to send silentFor containing the previous conversation.name, and verify the request matches the in-progress backend API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- api, mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100