nextcloud / nextcloud/talk-android
Crash when revoking notification permission
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
With https://github.com/nextcloud/talk-android/pull/4476 there will be a bug introduced:
The app crashes whenever notification permission for the app is set to false in in the android settings. This crash happens immediately when doing the change in the android settings, so not when navigating back.
As it should not happen that often that users disable the permission it's not a blocker.
I did not figure out the reason, it might be some architecture related and/or async problems..
I only found this similar/same issue for another app:
https://github.com/OneSignal/react-native-onesignal/issues/1629
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the crash after disabling notification permission in Android settings, then inspect the changes introduced by pull request #4476 and the related permission-handling flow. Done means changing the permission does not crash the app, including when the change happens immediately in settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100