nextcloud / nextcloud/talk-android
call buttons are shown when they shouldn't ("call buttons were null when trying to disable them")
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
Steps to reproduce
open a conversation where the call buttons should be disabled. For example "Note to self".
Expected behaviour
call buttons are disabled
Actual behaviour
call buttons are enabled
Log: "call buttons were null when trying to disable them"
conversationVoiceCallMenuItem and conversationVideoMenuItem are null.
Handling related to onPrepareOptionsMenu must be improved?
I can imagine that sometimes it works and sometimes not, as there could be a race condition.
Nextcloud Talk app version
19.1.0 Alpha 04 (most likely since ever)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening the “Note to self” conversation and inspect the call menu handling around onPrepareOptionsMenu, especially conversationVoiceCallMenuItem and conversationVideoMenuItem. Confirm the behavior across repeated openings to assess the suspected race condition. Done means call buttons are disabled when calls should be unavailable and the null-item log no longer occurs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100