nextcloud / nextcloud/talk-android

Get pending federation invitations from header (instead invitations endpoint)

Open
#3,811 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: federation 🌐
Dominant language
Kotlin
Stars
739
Forks
321
Avg merge
14h 59m
Merged PRs (30d)
151

Description

blocked by #https://github.com/nextcloud/talk-android/issues/217

Pending invitations for federation can now be received from server in the "get rooms" header. The talk app still uses the invitations endpoint to get these infos.

Using these infos from get rooms header will work for one account, but with multiple accounts this approach won't be able to show a badge whenever there are pending invitations for other accounts.

Right now i request pending invitations for all accounts when the conversation list is shown. If there are pending invitations for other accounts, a badge (red dot) is shown on the account avatar.

So for the iOS app it may make sense to request rooms for all accounts (to store everything in database) and then have the pending invitations infos as well.
For the android app, requesting rooms for all accounts at once is not done yet as there is no offline support.
So for the android app it's maybe better to wait with this until we finally implement offline support.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the dependency in issue #217, then inspect the Android app's current invitations-endpoint flow and the get rooms response header. Clarify whether offline support and requesting rooms for all accounts are prerequisites before defining the change; done should include pending-invitation badges for the relevant accounts without relying on the invitations endpoint.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.