nextcloud / nextcloud/talk-android
generic approach to send call reactions
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 739
- Forks
- 321
- Avg merge
- 14h 59m
- Merged PRs (30d)
- 151
Description
followup for https://github.com/nextcloud/talk-android/pull/2984
as stated by @danxuliu :
The signaling messages should not be sent using the PeerConnectionWrapper, because there might not be a connection with another participant (for example, if publishing audio and video is blocked for both participants).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review pull request 2984 and the current PeerConnectionWrapper usage first. Trace how signaling messages for call reactions are sent, then define and implement a generic path that does not depend on a participant connection; done means reactions can be signaled when both participants have audio and video publishing blocked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- audio-video-rtc, mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100