Only issue one notifications if content and assignment would both be issued otherwise
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 52
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 82
Description
Following up from discussions on https://github.com/nextcloud/tables/pull/2681#pullrequestreview-4582177255
I argued
When both content notifications and assignment notifications are enabled, it leads to two notifications. Imo this is not necessary and the assigned one is already sufficient. Can we only emit this one, if otherwise two would be send?
@marcoambrosini seconded:
About the double notification, I agree with youy that that's redundant. Let's always show the most specific one.
Most specific would be the assignment one as it specific to the user. Possible they can be combined into one as well?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the code that emits content and assignment notifications, then trace the case where both are enabled; done means only the assignment notification is emitted when both would otherwise be sent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100