"Save" button displaced
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 52
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 82
Description
Steps to reproduce
- have Table with multiple columns
- click "Edit row" button □ on a row → "Edit row" dialog opens
Expected behavior
Save button is a visible/accessible dialog action.
Actual behavior
Save button is not visible/accessible until user scrolls all the way down.
Tables app version
0.9.5
Browser
Vivaldi 7.7.3851.52
Client operating system
Windows
Operating system
Ubuntu
Web server
Apache
PHP engine version
PHP 8.2
Database
MariaDB
Additional info
Workaround
Cut the html element <div class="row">...</div> which holds the Save button and paste it inside the <div class="dialog__actions">[insert here]</div> and it looks almos fixed.
Bug or Feature ?
It will be debated if this is a feature. From a UX perspective it is a bug, because it is poor usability. If you do not agree, feel free to downgrade this to a feature request.
Closely related is a matter of taste, whether the save button belongs "inside" or "around" the dialog content. If debate becomes too hot, make it configurable/switchable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Edit row dialog in the Tables app and inspect the HTML around the div.row containing the Save button and div.dialog__actions. The issue is done when the Save action remains visible and accessible without scrolling through the dialog.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100