nextcloud / nextcloud/tables

Adjust display of error messages in TableCellLink for improved usability

Open
#2,013 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
214
Forks
52
Avg merge
1d 10h
Merged PRs (30d)
82

Description

Adjust this code in loadResultsForProvider(providerId, term) in TableCellLink.vue:

let res = null
	try {
		res = await axios.get(generateOcsUrl('/search/providers/' + providerId + '/search?term=' + term))
	} catch (e) {
		displayError(e, t('tables', 'Could not load link provider results.'))
		this.setProviderLoading(providerId, false)
		return
	}

consider combining errors from multiple providers—right now each failure (like network issues or provider unavailability) pops up its own message, which could get a bit much for users. A single, combined error might feel smoother

Originally posted by @silverkszlo in https://github.com/nextcloud/tables/pull/1977#discussion_r2276855635

Yeah, makes sense. And right now that I have added the link validation, trying to save several times by hitting enter multiple times with an invalid link leads to multiple popups with the same message. Could be improved for sure

Originally posted by @enjeck in https://github.com/nextcloud/tables/pull/1977#discussion_r2280971961

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in TableCellLink.vue at loadResultsForProvider(providerId, term), especially the axios request and displayError call. Trace how multiple provider failures and repeated invalid-link saves surface messages, then verify that related errors are presented together or without duplicate popups.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.