nextcloud / nextcloud/tables

Unit tests for Usergroup column parsing

Open
#1,994 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests
Dominant language
JavaScript
Stars
214
Forks
52
Avg merge
1d 10h
Merged PRs (30d)
82

Description

it would be nice to also have a test for the selection column, considering we have https://github.com/nextcloud/tables/blob/main/tests/unit/Service/ColumnTypes/TextLinkBusinessTest.php too

Originally posted by @enjeck in https://github.com/nextcloud/tables/pull/1887#pullrequestreview-3050299822

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/unit/Service/ColumnTypes/TextLinkBusinessTest.php, which is named as the comparable unit test, and locate the corresponding Usergroup column parsing tests. Add coverage for the selection column parsing and confirm the unit test suite passes with that case included.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.