nextcloud / nextcloud/tables

(not only) favorites data is not being deleted when a user is deleted

Open
#1,541 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
214
Forks
52
Avg merge
1d 10h
Merged PRs (30d)
82

Description

Steps to reproduce
  1. as User A favorite a table or view
  2. as admin, delete User A
  3. as admin, check select * from oc_tables_favorites where user_id = 'User_A';
Expected behavior

No results

Actual behavior

Rows are returned.

Tables app version

main

Browser

No response

Client operating system

No response

Operating system

No response

Web server

None

PHP engine version

None

Database

None

Additional info

We have a UserDeleted listener that deletes table data, but not favorite data. Contexts could be a thing, but tricky when shared. Shares can also be a thing. And navigation settings of contexts.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the UserDeleted listener mentioned in the issue and the deletion path for oc_tables_favorites. Reproduce the User A scenario, then determine how related contexts, shares, and navigation settings should be handled, including shared data. Done means deleting a user leaves no unintended user-owned rows, verified with the provided query and relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend, database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.