Error when trying to save edited view
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 52
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 82
Description
Steps to reproduce
- Pick any view
- Try to make some modifications, eg, change the order of columns or make some of the columns not to be displayed (untick the box)
- Got unknown error
Expected behavior
The views can be modified as earlier
Actual behavior
Getting error when trying to modify the views.
Error log shows: An invalid request occurred: Invalid column ID provided
Tables app version
0.8.1
Browser
Brave 1.7.126
Client operating system
Pop_OS 22.04
Operating system
Ubuntu 22.04
Web server
Apache
PHP engine version
PHP 8.2
Database
MariaDB
Additional info
Raw log:
{"reqId":"9KfhpcCLuI8qbOES3v6U","level":2,"time":"2024-10-20T10:28:01+03:00","remoteAddr":"fd:0:0:8101::1","user":"username","app":"tables","method":"PUT","url":"/index.php/apps/tables/view/6","message":"An invalid request occurred: Invalid column ID provided","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36","version":"29.0.8.1","exception":{"Exception":"InvalidArgumentException","Message":"Invalid column ID provided","Code":0,"Trace":[{"file":"/var/www/html/nextcloud/apps/tables/lib/Controller/ViewController.php","line":90,"function":"update","class":"OCA\\Tables\\Service\\ViewService","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/nextcloud/apps/tables/lib/Controller/Errors.php","line":22,"function":"OCA\\Tables\\Controller\\{closure}","class":"OCA\\Tables\\Controller\\ViewController","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/nextcloud/apps/tables/lib/Controller/ViewController.php","line":89,"function":"handleError","class":"OCA\\Tables\\Controller\\ViewController","type":"->"},{"file":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":232,"function":"update","class":"OCA\\Tables\\Controller\\ViewController","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":138,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/nextcloud/lib/private/AppFramework/App.php","line":184,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/nextcloud/lib/private/Route/Router.php","line":331,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/html/nextcloud/lib/base.php","line":1058,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/html/nextcloud/index.php","line":49,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/html/nextcloud/apps/tables/lib/Service/ViewService.php","Line":275,"message":"An invalid request occurred: Invalid column ID provided","exception":[],"CustomMessage":"An invalid request occurred: Invalid column ID provided"},"id":"6714b1d08051f"}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/Service/ViewService.php at line 275 and the update call in lib/Controller/ViewController.php at line 90. Reproduce the error by changing a view's column order or visibility, then trace which column IDs are submitted. Done means edited views save successfully without the invalid column ID error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mariadb, php
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100