Prevent accidentally leaving *Edit row* with ESC while having unsaved changes
Open
Nobody has claimed this yet.
0. Needs triage
bug
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 52
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 82
Description
Steps to reproduce
- Create a table with a text column
- Add a row
- Open the edit row modal
- Add a link to the text -> the link preview popover shows
- Click Esc because I intuitively think this would close the popover
Expected behavior
The popover closes or nothing happens. But the modal stays open with my changes.
Actual behavior
The modal closes, my changes are lost.
Tables app version
No response
Browser
No response
Client operating system
No response
Operating system
No response
Web server
None
PHP engine version
None
Database
None
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the Tables app using the listed steps, then inspect the Edit row modal and link preview popover handling for Escape. Done means Escape closes the popover or does nothing while the modal remains open and unsaved changes are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100