nextcloud / nextcloud/suspicious_login

WebDAV connections fail with Suspicious Login enabled [Flysystem]

Open
#509 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
106
Forks
32
Avg merge
8h 33m
Merged PRs (30d)
10

Description

Hi all,

when Suspicious Login is enabled, all WebDAV connection attempts fail and following fatal log message is generated:

TypeError: Argument 1 passed to League\Flysystem\Filesystem::__construct() must be an instance of League\Flysystem\AdapterInterface, instance of League\Flysystem\Local\LocalFilesystemAdapter given, called in /var/www/nextcloud/apps/suspicious_login/vendor/rubix/ml/src/Persisters/Filesystem.php on line 32

Could someone please give me a clue for a workaround or is this really something that needs to be fixed?
I'm not a coder, unfortunately, I cannot address the problem on my own.

Kind regards,

christian

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing a WebDAV connection with Suspicious Login enabled and inspect the TypeError at vendor/rubix/ml/src/Persisters/Filesystem.php line 32. Compare the Flysystem types used there with the installed adapter, then verify that WebDAV connections complete without the fatal error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.