nextcloud / nextcloud/suspicious_login

Allow users to opt-out from login alerts

Open
#38 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
106
Forks
32
Avg merge
8h 33m
Merged PRs (30d)
10

Description

I can imagine that not all users care about these events and might want to disable the notifications for their account.

There is also the case where a user has clients connected that use the login password. In that case the classifier might very often warn about a login, though there was none. For flawless security we can't duck type a connection to being a client because attackers can also just use a Nextcloud client to access the victim's data. Hence the separation of web login and client access does not help here.

The proposed solution is a simple checkbox on the user's personal settings page that default to checked. If unchecked, the app will never send out notifications.

cc @rullzer as discussed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the personal settings page and the login-notification sending flow; done means a checked-by-default opt-out setting prevents notifications for that account when unchecked.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.