Add hover and speaking shadow on the ViewerOverlay
Open
@ShGKme is already working on this.
Since May 23, 2023.
bug
feature: call 📹
feature: frontend 🖌️
feature: upload & shares & voice 📤🎙️
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Use the light theme
- Start a call
- Open a file in a viewer
- Hover the ViewerOverlay
- Add participant to a call
- Hover the ViewerOverlay
- Start speaking from the second participant
Expected behaviour
There is always a hover effect and the speaking-shadow effect.
Actual behaviour
There is no effect.
Proposals
Originally shadow effect was disabled because it was always white on the call view in Talk and invisible on the light theme.
What should we do?
- Use effect with theming - a dark shadow on the light theme
- Use an opacity effect instead of the shadow
- 0.8 initially
- 0.9 speaking
- 1.0 on hover
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.