Cannot 'Join conversation' of a file inside a group folder I already had permissions, after it has been shared to me again.
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
-
Please use the 👍 reaction to show that you are affected by the same issue.
-
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
-
Subscribe to receive notifications on status change and new comments.
Bug description
I cannot 'join conversation' of a file in a group folder I already have access to, when it has been shared again with me through the 'search for share recipients' function.
Instead, I am invited to re-share the file.
Steps to reproduce
-
Alice creates a file in a group folder to which Bob has already access to
-
Alice shares the file with Bob through the 'search for share recipients' function by finding and clicking his name
-
When Bob finds the file in that group folder and enters the 'Chat' sub-menu of that file, he cannot find 'Join conversation'. Instead, he faces a 'Share this file' button.
-
If Bob clicks 'Share this file', as wrongly indicated (because it already is in a group folder), Bob is redirected to the 'Sharing' sub-menu of the same file.
-
Alternatively, if Bob enters his personal folder 'Shared' and finds the file, inside the 'Chat' sub-menu, the 'Join conversation' button is being shown. However, if he clicks on it, nothing happens.
See below for videos of the behavior. The console indicates an error each time I click the relevant button.
Expected behaviour
Bob is able to press the 'Join conversation' button and join the conversation.
'Share this file' button not being shown at all.
Actual behaviour
If Bob clicks 'Share this file', as wrongly indicated (because it already is in a group folder), Bob is redirected to the 'Sharing' sub-menu of the same file.
Alternatively, if Bob enters his personal folder 'Shared' and finds the file, inside the 'Chat' sub-menu, the 'Join conversation' button is being shown. However, if he clicks on it, nothing happens.
Talk app
Talk app version: Talk 15.0.5
Custom Signaling server configured: yes. high-performance backend
Custom TURN server configured: yes
Custom STUN server configured: yes
Browser
Microphone available: yes
Camera available: yes
Operating system: Ubuntu/Windows
Browser name: Edge
Browser version: Version 110.0.1587.69
Browser log
Console output in attached videos
Server configuration
Operating system: Ubuntu
Web server: None
Database: MySQL
PHP version: 8.1
Nextcloud Version: 25
List of activated apps:
Available upon request
Nextcloud configuration:
Available upon request
Server log (data/nextcloud.log)
Available upon request
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the sharing flow in Nextcloud Talk 15.0.5: share a file from a group folder to a user who already has access, then compare the Chat submenu with the personal Shared folder and review the console errors. Done means the correct Join conversation action appears for the group-folder file, works when clicked, and Share this file is not shown incorrectly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100