Share files with correct path and not into folder "talk"
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 350
Description
We have a group with all team members and a common folder with all commonly used files that is shared to that group. Whenever one attaches a file of that shared folder to a card in deck and one team member clicks on that card it is opened showing inside the common folder.
However, whenever someone shares such a file in talk and then opens it, it points to the "talk" folder instead of the common shared folder. When you then delete this file from the talk folder (Freigabe verlassen), go back to talk and open it then, it points you to the correct place inside the shared folder.
For me it looks like talk always "shares" a shared file directly to everyone in the chat without checking in advance if the folder the file is from is already shared to the members of the chat.
For working with files it sometimes make sense to reveal the folder structure as well so that you can see the context of that file. So it would be good to implement a check if the file is already shared to the members of the chat before sharing it again.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Trace how Talk shares attached files and resolves their displayed folder, then verify behavior for files already shared through a common folder and for files that need direct sharing; done means opening the file shows its existing shared-folder context without an unnecessary Talk-folder share.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100