nextcloud / nextcloud/spreed

Move all validateBackendRequest() functions to a shared service

Open
#8,745 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature: SFU & SIP ☎️ feature: signaling 📶 technical debt
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

Can we move this to SIPBridgeService (With renaming it as initially suggested back then) and deduplicate the logic?

Originally posted by @nickvergessen in https://github.com/nextcloud/spreed/pull/8708#discussion_r1102436677

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate all validateBackendRequest() functions and inspect SIPBridgeService, including the linked discussion for the proposed rename. Done means the functions are consolidated there under the agreed name and their duplicated logic is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.