Improve Talk HPB validation check by checking the shared secret
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
When configuring the Talk HPB in the Talk admin settings, a check is performed on the user-entered parameters. The check doesn't take into account the shared secret as it just runs a request to the api/v1/welcome endpoint, that doesn't require authentication. This can be misleading as the connection will fail with a wrong shared secret.
Describe the solution you'd like
Let the Talk HPB validation check to take into account the shared secret as well.
Describe alternatives you've considered
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Talk admin settings validation and the api/v1/welcome endpoint mentioned in the issue. Trace how the validation request is built and how the shared secret is passed, then verify that a wrong secret fails validation while valid Talk HPB parameters succeed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, authentication, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100