Reparent viewer in fullscreen mode
Open
Nobody has claimed this yet.
bug
feature: frontend 🖌️
technical debt
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
By default the viewer is a sibling of the fullscreen element, so it is not visible when in fullscreen mode. In #6879 the viewer is reparented shortly after opening it in fullscreen mode, but this hack should be removed once it is possible to specify the parent element of the viewer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the fullscreen viewer handling referenced in #6879 and the dependency on nextcloud/viewer#995. Confirm how the viewer is reparented after opening in fullscreen; this is done when the viewer can accept a specified parent element and the workaround can be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- audio-video-rtc, frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100