Reparent file picker in fullscreen mode
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
By default the file picker is a sibling of the fullscreen element, so it is not visible when in fullscreen mode. In #6879 the file picker is reparented shortly after opening it in fullscreen mode, but this hack should be removed once it is possible to specify the parent element of the file picker.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading #6879 and the dependency issue nextcloud/nextcloud-dialogs#427 to understand the current fullscreen reparenting workaround and the supported parent-element API. Done means removing that workaround once the dependency supports it and confirming that the file picker remains visible in fullscreen mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100