nextcloud / nextcloud/spreed

Reparent file picker in fullscreen mode

Open
#6,881 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: frontend 🖌️ technical debt
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

By default the file picker is a sibling of the fullscreen element, so it is not visible when in fullscreen mode. In #6879 the file picker is reparented shortly after opening it in fullscreen mode, but this hack should be removed once it is possible to specify the parent element of the file picker.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading #6879 and the dependency issue nextcloud/nextcloud-dialogs#427 to understand the current fullscreen reparenting workaround and the supported parent-element API. Done means removing that workaround once the dependency supports it and confirming that the file picker remains visible in fullscreen mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.