Delay freespace calculation until the user tries to interact with the file share option or starts dropping a file
Open
Nobody has claimed this yet.
bug
feature: upload & shares & voice 📤🎙️
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
Steps to reproduce
- Load a page which triggers BeforeTemplateRenderedEvent
- See that Talk does some filecache operations
Expected behaviour
Should only be done when needed, which is when the user actually starts dropping a file on the chat view or opens the menu.
From my POV it would be okay if this is only triggered/checked when the upload dialog shows
Actual behaviour
Are done on each rendering due to sidebar integrations
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the sidebar integrations triggered during BeforeTemplateRenderedEvent, then locate the file-share menu and file-drop handlers that perform the filecache operations. The change is done when rendering the page no longer calculates freespace, while opening the upload dialog or beginning a file drop still performs the required check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100