Add margin to the right of the chat the same size of the sidebar in 1on1s
Nobody has claimed this yet.
- #6762 by @nikola-gladovic — closed without merging
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
how to reproduce:
1 Have a 4k monitor without scaling turned on
2 Open a group conversation and open the sidebar
3 Switch to a 1on1 conversation
Expected behavior:
The chat and newmessageform stay in place (horizontally aligned) and a margin the size of the sidebar is added to the right of the page
Actual behavior:
The chat jumps to the right
the isMobile is not really helpful here as we want to introduce this margin only when
windowWidth - navigationWidth - sidebarWidth > 800px
800px being the size of the message component including the avatar part. We don't want to needlessly compress that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the layout change on a 4k monitor by opening a group conversation with the sidebar, then switching to a 1on1. Start by tracing the chat and newmessageform layout and the existing isMobile, windowWidth, navigationWidth, and sidebarWidth handling. Done means the chat stays horizontally aligned and gains the sidebar-sized right margin only when the remaining width exceeds 800px.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100