nextcloud / nextcloud/spreed

Honour revoked publishing permissions for remote participants even if remote participants do not

Open
#5,928 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: call 📹
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

Extracted from #5693

The remote participants should honour their publishing permissions, but even if they do not, the clients should ignore the received streams of a remote participant without publishing permissions (similar to the safeguard applied to "force mute" messages):

  • Do not try to connect to a participant without publishing permissions even if the participant is publishing
    • The HPB blocks offers from participants without publishing permissions, so this would not be strictly needed in that case
  • Stop the connection with a remote participant when the permissions are revoked even if that participant keeps publishing
    • The HPB does not stop the connections when publishing permissions are revoked, so even with the HPB a remote client could misbehave

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Begin by tracing the client entry points that decide whether to connect to remote participants and handle revoked publishing permissions, then compare that flow with the force-mute safeguard mentioned in the issue. Done means unauthorized streams are ignored and connections stop when publishing permission is revoked.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
audio-video-rtc, authorization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.