nextcloud / nextcloud/spreed

Improve selection of simulcast streams

Open
#5,919 2 comments 1 reaction 1 assignee View on GitHub

@danxuliu is already working on this.

Since May 10, 2022.

bug feature: call 📹 feature: frontend 🖌️ high
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

Extracted from #5535

Currently the simulcast streams are set as follows:

  • If call view is in grid mode -> Medium quality
  • If a participant is selected or promoted -> High quality
  • Otherwise -> Low quality

However, this does not take into account the actual size of the cells in the grid, or that if a participant is selected the promoted participants will not be shown in the main view.

This could be improved, for example, with the following approach:

  • If a participant is selected:
    • Selected participant -> High quality
    • Any other participant fallback to the grid quality
  • If no participant is selected but a participant is promoted and the call view is in speaker mode:
    • Last promoted participant -> High quality
    • Any other participant fallback to the grid quality
  • If the call view is in grid mode, or for any other participant besides the promoted and selected ones in speaker mode (they will be shown also in a grid below the main speaker):
    • Set quality based on the size of the cells of the grid

What would need to be defined (and thoroughly tested) is the threshold used for each quality and each cell size 🤷

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.