nextcloud / nextcloud/spreed

Missing TURN server message should be shown only if there was never a connection with the peer

Open
#5,338 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: call 📹 feature: frontend 🖌️
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

iceConnectionState will be set to failed if the ICE negotiation fails. However, it could happen too if there was a working connection with the peer but the connection fails for some reason. In that case the missing TURN server message would be misleading, as the TURN server would not have solved the issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/utils/webrtc/webrtc.js at the missing TURN server message around line 585, and inspect how iceConnectionState changes are handled. The message should appear only when the peer has never had a working connection; verify the behavior for both initial ICE failure and a later connection failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
audio-video-rtc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.