Remove room description field in video verification room
Open
Nobody has claimed this yet.
bug
feature: frontend 🖌️
feature: settings ⚙️
good first issue
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
Steps to reproduce
- Share a file with link
- Set a password
- Enable video verification
- Open in a separate browser
- Click "request password"
- As the share owner, go to the Talk app
- Join the "Password request: xxx" room
- Check the right sidebar
Expected behaviour
No description field
Actual behaviour
Description field is visible, it shouldn't be there.
Note: the description is also not visible for 1-1 chats nor for file chat rooms. So we were probably missing a condition.
Talk app
Talk app version: git master
@ma12-co FYI if interested
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Talk app's room sidebar rendering and reproduce the password-request flow described in the issue. Trace the condition controlling the description field, then verify that it is absent in video verification rooms while remaining unaffected in other room types mentioned, including 1-1 chats and file chat rooms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- audio-video-rtc, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100