nextcloud / nextcloud/spreed

Previous page button focused when changing to second page in grid

Open
#4,961 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: call 📹 feature: frontend 🖌️
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
17h 55m
Merged PRs (30d)
350

Description

How to test

  • Enable devMode in grid view and rebuild JavaScript files
  • Start a call
  • Change to speaker mode
  • With the default 10 dummies and with a screen width of 1920px the grid in the stripe should have 2 pages; if not resize the browser window as needed (or change the number of dummies)
  • Click on the button to change to the next page
Expected result

As the next page button is removed no button is focused.

Actual result

The previous page button is focused.

Note that if there are 3 or more pages when reaching the last page the previous button is not focused. Moreover, if going from the second page to the first one after the previous page button is removed no button is focused, no matter how many pages there are in total. It only happens when there are 2 pages and when going from the first page to the second one 🤷

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the devMode grid setup and pagination controls in src/components/CallView/Grid/Grid.vue, especially the referenced lines. Reproduce the two-page scenario in a call and inspect focus as the next page replaces the previous-page button. Done means no button is focused when moving from the first page to the second, while the other described cases remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.