"Search for more users" should only be displayed if there are more users that can be displayed
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
Steps to reproduce
- Create a new group conversation
- Add a name and click "Add participants".
- Scroll down inside the popup window.
Expected behaviour
"Search for more users" should only be displayed if there are more users that can be displayed or if interaction is possible for me at that moment to search for other users.
Actual behaviour
While "Add User" and "Add Groups" offer me an action, Search does not allow me any further interaction when creating a new conversation.
Talk app
Talk app version: (see apps admin page: /index.php/settings/apps)
v10.0.5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Talk app's new group conversation flow, specifically the Add participants popup and its "Search for more users" entry. Reproduce the empty-result state and trace the participant list logic; done means the search option is shown only when more users can be displayed or searching is actionable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100