nextcloud / nextcloud/spreed

Session expiration is only triggered when the participants are got

Open
#4,650 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: api 🛠️ feature: signaling 📶 regression
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

Before Talk 9 sessions were expired when the information for a conversation was fetched. Since the introduction of the RoomV2 API fetching the room conversation no longer queries the participants, and thus the sessions are no longer expired in that case. To solve that session expiration was brought back, but only when the clients fetch the participants of a conversation.

This causes that sessions are not properly expired in some cases, for example, in video verification conversations or in public conversations.

How to test (scenario 1)

  • Open the Files app
  • Share a file by link
  • Enable video verification for that link
  • In a private window, open the link
  • Repeat the two steps below until the page is refreshed but leaveRoom is not called
    • Request the password
    • Refresh the page
  • In the original window, open Talk
Expected result

After some time the password request conversation is no longer shown in the conversation list.

Actual result

The password request conversations are kept in the conversation list forever (until the user enters that conversation, then the participants are got and the conversation is destroyed).

How to test (scenario 2)

  • Open Talk
  • Create a public conversation
  • Copy the link
  • Logout
  • Open the link
  • Repeat the three steps below until the window is closed but leaveRoom is not called
    • In a private window, open the link
    • Set a user name
    • Close the private window
  • In the original window, try to mention the other guest
Expected result

After some time the candidate mentions no longer include the guest that left.

Actual result

The guest that left will be shown in the candidate mentions until a user enters the conversation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/Controller/RoomController.php at the referenced leaveRoom entry point, then trace how session expiration is triggered when room information and participants are fetched. Reproduce both linked scenarios and verify that expired password-request sessions and departed public guests no longer remain in conversation lists or mention candidates.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.