nextcloud / nextcloud/spreed

Leave call when closing files sidebar

Open
#4,373 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: talk-sidebar ⬅️
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

Steps to reproduce

  1. Share a file with other people
  2. Start a call in the sidebar for that file
  3. Close the sidebar
  4. Redo the steps but this time switch to another file during the call.
Expected behaviour

A warning appears, telling me that I'm about to leave the call.
If I accept, the call ends and context is switched.
Otherwise the sidebar stays open.

Actual behaviour

The sidebar closes, the call is ongoing.
If I click on other files, somehow it seems the chat window is still the one from the current file (might be another bug).
There is a risk that I get lose in other folders and don't remember where the call is happening.

In the files app the context can be switched to another file, so to me it makes sense to end the call.
However, if a file is currently open (ex: office doc or markdown), then closing the sidebar should not end the call but maybe an indicator should be shown somewhere that a call is ongoing.

Talk app

Talk app version: 11.0.0-dev.2 (from git master)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the call, sidebar-close, and file-switch flows in the Files app with the Talk sidebar. Trace the existing handling for closing the sidebar and switching file context, then verify the warning, call termination, context switch, and ongoing-call indication described in the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
audio-video-rtc, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.