Keep chat open in case of errors (like 404)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
Steps to reproduce
- Create a chat with 500+ users and all users present (like the NC conf!)
- Add a few partitipants
- ??? somehow the server is under load ???
- Wait
Expected behaviour
Chat channel stays, maybe a message appears or a spinner.
Return a 503 from the API and catch it on the side.
Actual behaviour
Chat says "conversation does not exist".
Perhaps a 404 was returned by an API.
Talk app
Talk app version: 10.0.0
Custom Signaling server configured: yes/no and version (see additional admin settings: /index.php/index.php/settings/admin/talk#signaling_server)
Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#turn_server)
Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#stun_server)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure described with a large chat and inspect the API response when the conversation is reported missing. Trace the Talk app's handling of that response and verify the chat remains open with an error message or spinner instead of showing that the conversation does not exist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100