nextcloud / nextcloud/spreed

Get rid of "[audio|video][On|Off]" datachannel events

Open
#397 6 comments 0 reactions 1 assignee View on GitHub

@Ivansss is already working on this.

Since Aug 31, 2017.

feature: WebRTC 🚡 standardisation technical debt
Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
18h 27m
Merged PRs (30d)
333

Description

As just discussed offline with @Ivansss : currently the UI sends videoOn/videoOff and audioOn/audioOff events through the datachannels to all connected clients to notify about what is available and what is currently sending.

This is not necessary as you can get the information on media types from the offer/answer, and get the state (paused/running) from the streams. In order to remove duplicate functionality and simplify the code, these events should be removed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.