Notifications for guest mentions?
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
With #1974 guests can now be mentioned in the chat.
But apart from a blue mention chip in the chat log, they can not be notified opposed to normal users with the notifications app which brings up browser notifications.
Maybe we should try to do some magic, to detect if a mention is new and then send a browser notification in similar fashion:
https://github.com/nextcloud/notifications/blob/master/src/components/Notification.vue#L231-L271
However we need to make sure, this does not trigger, when scrolling up and down or when the chat history is reloaded, etc.
Since this requires quite some hacking in the Frontend, i guess it could be delayed until after the Vue project
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced notifications app component, Notification.vue lines 231-271, and the guest-mention behavior introduced by #1974. The feature would need to notify guests in the browser for genuinely new mentions while avoiding notifications during scrolling or chat-history reloads; the issue suggests this may wait until after the Vue project.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100