Followups: Don't send all room userids in signaling server requests
Open
Nobody has claimed this yet.
bug
feature: api 🛠️
feature: call 📹
feature: signaling 📶
performance 🚀
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
- Handle updates of many participants that can still cause an error
- Include inactive participants in the list of changed participants in
BackendNotifier::participantsModified() - Notify missing room changes, like avatars or in call status
- Notify inactive participants when a room is modified
Originally posted by @danxuliu in https://github.com/nextcloud/spreed/pull/16759#pullrequestreview-4684241239
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing BackendNotifier::participantsModified() and the signaling server request construction, using the follow-up context from pull request 16759. Check how participant and room changes are collected, then verify that large participant updates, inactive participants, avatars, and in-call status are all notified without sending every room userid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100