nextcloud / nextcloud/spreed

Period breaks mention

Open
#18,453 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: chat 💬 feature: frontend 🖌️
Dominant language
JavaScript
Stars
2.2k
Forks
586
Avg merge
18h 27m
Merged PRs (30d)
333

Description

[!TIP]

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Write a talk message, start typing "@..." and select something from the mention popup. The mention pill is inserted followed by a space character.
  2. Hit backspace to delete the space character (needed in some cases like you want to end a sentence with the mention or want a comma directly after the mention) and add a period (".") after the mention.
  3. Send the message.
Expected behaviour

In the sent message, the mention should still work and be displayed as a pill.

Actual behaviour

In the sent message, the mention is broken and not displayed as a pill anymore.

Talk app

Talk app version: 23.0.6
Nextcloud version: 32/33

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the Talk app using the mention popup, then trace how a mention is represented when a message is sent after removing its trailing space and adding a period. Done means the sent message still displays the mention as a working pill in this punctuation case; the payload names no specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.