Dial-in room participant added as guest, not as a phone participant
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
[!TIP]
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
When a call is using direct dial-in, the phone participant is added as guest, not as a phone participant. Therefore it is not recognized by the frontend as a phone participant and calling back is not possible.
Ref https://github.com/nextcloud/spreed/blob/b9e35b0bef074be45c0fec5580c129c2bf4163db/lib/Controller/RoomController.php#L2364
Talk app
Talk app version: 34/main
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/Controller/RoomController.php around line 2364 and trace how a direct dial-in participant is created. Then inspect the frontend handling for phone participants and callback behavior. Done means the dial-in participant is recognized as a phone participant rather than a guest and can be called back.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- audio-video-rtc, full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100