Wrong Offset auto-scroll when there is unread mentions in LeftSidebar
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
getFirstItemInViewportIndex, getLastItemInViewportIndex, getItemOffset are not taking into account ConversationTagHeader items: they are rendered and taking height, but not considered when you counting unreadMentionIndices. That's why scroll to bottom, and computing when to show a button has slightly offset with tags used.
Originally posted by @Antreesy in https://github.com/nextcloud/spreed/issues/18036#issuecomment-4500519351
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the LeftSidebar code and locate getFirstItemInViewportIndex, getLastItemInViewportIndex, and getItemOffset. Trace how unreadMentionIndices is counted alongside rendered ConversationTagHeader items, then verify that scrolling to the bottom and the button visibility calculation stay aligned when tags are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 66/100