Entering a conversation does multiple reaction requests
Open
Nobody has claimed this yet.
bug
feature: frontend 🖌️
feature: reactions 👍
performance 🚀
regression
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Enter a conversation on main
- Observe network requests
Expected behaviour
No dedicated requests for revoked reactions
Actual behaviour
/ocs/v2.php/apps/spreed/api/v1/reaction/.../1307
So happens for every revoked reaction.
Talk app
Talk app version: locally (main) and sermo
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/stores/reactions.js at lines 195-197 and reproduce the issue by entering a conversation on main while observing network requests. The work is complete when entering a conversation no longer sends dedicated requests for revoked reactions; verify that this applies to every revoked reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100