Prevent "Background"-Folder creation for guest users
Open
Nobody has claimed this yet.
bug
feature: frontend 🖌️
feature: upload & shares & voice 📤🎙️
Needs triage
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Be a guest user (from the guests app)
- Open the media settings in talk
While the upload button is hidden, we still try to create the Backgrounds folder:
(not totally sure why the Talk/ part is missing, I've seen the error for the correct path for guest users)
If we know we cannot upload anything, we should not try to create the folder.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/components/MediaSettings/VideoBackgroundEditor.vue around lines 178-186 and reproduce the guest-user flow from the Talk media settings. Verify that guest users, who cannot upload, no longer trigger creation of the Backgrounds folder.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100