Conversations on files displayed as public
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
Steps to reproduce
- Make sure to enable Conversations on files in /settings/admin/talk
- In Nextcloud files, open the details sidebar of a shared file and select Chat -> Join Conversation
-> A conversation is created and displayed in the sidebar. - In Nextcloud talk, open that conversation and open the conversation settings.
- Under Moderation, "Guests are allowed to join this conversation via link" is activated and cannot be changed.
- Copy the Guest Link, try it in a private browser window and see how it is not working (which is good).
Expected behaviour
The conversation should not be displayed as public.
Actual behaviour
The conversation should display as a "normal" (non-public) conversation and the link should work, but only as a normal, internal link, that can be opened just by logged-in users to join the conversation.
Talk app
Talk app version: 21.1.5
Nextcloud
** Nextcloud Server version:** 31.0.9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the flow from Nextcloud Files' details sidebar to Talk conversation settings, focusing on the Moderation option and Guest Link behavior. Trace how the conversation created through Conversations on files is classified, then verify that it is shown as normal and that its internal link is usable only by logged-in users.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authorization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100