Reduce verbosity of PeerConnectionAnalyzer logs
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.2k
- Forks
- 587
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
When the PeerConnectionAnalyzer detects that the connection quality is bad the different values used to compute the quality as well as a list of recent raw RTC stats are printed. When the connection quality is bad it is usually bad for several seconds, and during that time every quality check causes the stats to be printed. The printed stats include historical values (from the last 5-7 seconds, depending on the stat type), and the checks are done every second, so in the end there is a lot of duplicated information logged.
Instead of printing the stats on every failed check they should be printed on the first failed check and, then, on the following failed checks if none of the stats to be printed were already printed before. If after some failed checks with no printed stats the connection improves and the connection quality is no longer bad the stats should also be printed again one last time so no stats are missing in the logs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/utils/webrtc/analyzers/PeerConnectionAnalyzer.js around lines 769-797, where failed quality checks print computed values and recent RTC stats. Trace the quality-check flow and existing logging state, then verify that the first failure logs, later failures log only newly available stats, and recovery produces one final log without duplicating prior stats.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- audio-video-rtc
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100