nextcloud / nextcloud/spreed

System message `reaction_revoked` should contain, which reaction was revoked

Open
#14,994 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement feature: api 🛠️ feature: frontend 🖌️ feature: reactions 👍 Needs triage
Dominant language
JavaScript
Stars
2.2k
Forks
586
Avg merge
18h 27m
Merged PRs (30d)
333

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Post a message
  2. Add a reaction
  3. Remove a reaction
Actual behaviour

POST to api/v1/reaction/{token}/{id}:

"data": {
    "\ud83d\udc4d": [
        {
            "actorType": "users",
            "actorId": "antreesy",
            "actorDisplayName": "Max Southgate",
            "timestamp": 1746019885
        }
    ]
}

DELETE to api/v1/reaction/{token}/{id}?reaction=%F0%9F%91%8D:

"data":{}

This also triggers GET request to api/v1/reaction/{token}/{id}, as other clients don't know, which and by whom a reaction was removed

GET messages after long polling, or chat loading:

[
  {
      "id": 576,
      "message": "{file}",
      "reactions": {
          "\ud83d\ude00": 1
      },
  },
  {
      "id": 577,
      "message": "Reaction deleted by author",
      "systemMessage": "reaction_deleted",
      "parent": {
          "id": 576,
      }
  },
  {
      "id": 578,
      "message": "You deleted a reaction",
      "systemMessage": "reaction_revoked",
      "parent": {
          "id": 576,
      }
  }
  {
      "id": 579,
      "message": "\ud83d\ude00", // This is missing on reaction_revoked
      "systemMessage": "reaction",
      "parent": {
          "id": 576,
          "reactions": {
              "\ud83d\ude00": 1
          },
      }
  }
]

Talk app

Talk app version: dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the POST and DELETE requests to api/v1/reaction/{token}/{id}, then trace how reaction_revoked system messages are generated and returned after long polling or chat loading. Done means the revoked reaction is included in reaction_revoked so clients do not need a follow-up GET request.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.