Guest with modified permissions shows up as a new attendee after page reload
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 586
- Avg merge
- 18h 27m
- Merged PRs (30d)
- 333
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
as moderator: M
as guest: G
- M - create public conversation with password
- G - enter password and join the conversation
- M - edit permissions of G
- G - reload the page
Expected behaviour
New session linked to the same attendee
Actual behaviour
Chrome
Incognito mode, and different Chrome account:
On page reload guest received a new session and a new entry in attendees list:
Firefox:
Reload works fine, guest received a new entry only after closing tab/browser and opening again:
Non-reproducible anymore after clearing the cache:
Chrome account after this procedures made two requests to /apps/spreed/api/v4/room/{token}/participants/active, first resulted in 412, second - 403 with { error: "password" }
Talk app
Talk app version: tested on main branch
Custom Signaling server configured: yes
Custom TURN server configured: no
Custom STUN server configured: no
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the moderator and guest steps, then inspect the requests to /apps/spreed/api/v4/room/{token}/participants/active during reload. The fix is complete when a guest with modified permissions remains linked to the same attendee instead of creating a new session and attendee entry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100